Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Purchase Order Destination #8403

Merged
merged 19 commits into from
Nov 1, 2024
Merged

Purchase Order Destination #8403

merged 19 commits into from
Nov 1, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat commented Oct 31, 2024 •
edited
Loading

  • Adds "destination" field to the PurchaseOrder model
  • Specify (at the order level) where items should be received into
  • Can be overridden by "destination" field on the PurchaseOrderLineItem model

TODO

  • Update documentation
  • Playwright testing

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature order Related to purchase orders / sales orders api Relates to the API migration Data or schema migrations labels Oct 31, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 31, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 31, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit bb0a12d
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67241582acdf0100086e17fc
😎 Deploy Preview https://deploy-preview-8403--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Oct 31, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.36%. Comparing base (871cd90) to head (bb0a12d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/plugin/base/barcodes/api.py 14.28% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8403      +/-   ##
==========================================
+ Coverage   84.35%   84.36%   +0.01%     
==========================================
  Files        1168     1169       +1     
  Lines       53250    53268      +18     
  Branches     1978     1978              
==========================================
+ Hits        44919    44941      +22     
+ Misses       7839     7823      -16     
- Partials      492      504      +12
Flag Coverage Δ
backend 85.97% <68.42%> (-0.01%) ⬇️
pui 67.76% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matmair
matmair approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@matmair matmair left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SchrodingersGat added a commit to inventree/demo-dataset that referenced this pull request Oct 31, 2024
@SchrodingersGat
Add "destination" field values for PurchaseOrder models.
e66111c 
Ref: inventree/InvenTree#8403
@SchrodingersGat SchrodingersGat mentioned this pull request Oct 31, 2024
Merged
SchrodingersGat added a commit to inventree/demo-dataset that referenced this pull request Oct 31, 2024
@SchrodingersGat
Add "destination" field values for PurchaseOrder models. (#82)
857cfc9 
* Add "destination" field values for PurchaseOrder models.

Ref: inventree/InvenTree#8403

* Add some more data
@SchrodingersGat SchrodingersGat merged commit c4031db into inventree:master Nov 1, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the po-destination branch November 1, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmair matmair matmair approved these changes

Assignees
No one assigned
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature migration Data or schema migrations order Related to purchase orders / sales orders
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SchrodingersGat @matmair